Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svg): don't style width/height in attributes with unit #5550

Merged
merged 2 commits into from Mar 16, 2023
Merged

fix(svg): don't style width/height in attributes with unit #5550

merged 2 commits into from Mar 16, 2023

Commits on Mar 16, 2023

  1. fix(svg): don't style width/height in attributes with unit 

    Browsers warn for a width/height attribute which isn't a number, as it can only be a "unitless value" (px). Despite that it does seem to work.

Components involved:
- SearchBox in Vue
- Panel in JS
- Refresh in hooks example
    @Haroenv
    Haroenv committed Mar 16, 2023
    Copy the full SHA
    92cd5a4 View commit details
    Browse the repository at this point in the history

  2. snapshot

    @Haroenv
    Haroenv committed Mar 16, 2023
    Copy the full SHA
    34d3171 View commit details
    Browse the repository at this point in the history