Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): move options diff to core #5908

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

refactor(core): move options diff to core #5908

wants to merge 3 commits into from

Commits on Oct 26, 2023

  1. refactor(core): move options diff to core 

    Still open questions
- how to do `insights` (does middleware need update option too?) (do we handle anything other than init props)
- how to warn/error for routing/onStateChange (or do we handle it?)
- test that it works properly of course
- should some of the code in constructor be moved to update?
    @Haroenv
    Haroenv committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    fb30d43 View commit details
    Browse the repository at this point in the history

  2. remove hasUpdated

    @Haroenv
    Haroenv committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    196b63e View commit details
    Browse the repository at this point in the history

  3. indication

    @Haroenv
    Haroenv committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    d7186ad View commit details
    Browse the repository at this point in the history