Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add missing modifierClick avoid preventDefault to links #5994

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jan 12, 2024

Summary

You should be able to cmd-click on every link rendered by InstantSearch and open it in a new tab. The default behaviour should never be prevented if it's a modifier or special click.

Result

  • Menu in React InstantSearch respects cmd-click
  • Breadcrumb in InstantSearch.js respects cmd-click

TODO:

  • tests (possibly something global that cmd-clicks on every link and shows the DOM didn't change?)
  • ensure there's no other cases of this pattern

TODO: tests (possibly something global that cmd-clicks on every link and shows the DOM didn't change?)
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0eed703:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant