Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): don't accept non-arrays for attributesToDisplay #6027

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jan 31, 2024

Summary

This makes it consistent with attributesForFaceting. See #6023 for more info, although it doesn't change that use case.

Result

attributesToDisplay must be an array in config.

This makes it consistent with `attributesForFaceting`. See  #6023 for more info, although it doesn't change that use case.
@Haroenv Haroenv requested review from a team, dhayab and aymeric-giraudet and removed request for a team January 31, 2024 11:59
@Haroenv Haroenv added the Library: Create InstantSearch App Issues in create-instantsearch-app label Jan 31, 2024
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 307f26d:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration

@Haroenv Haroenv merged commit 0dbeb82 into master Feb 2, 2024
12 checks passed
@Haroenv Haroenv deleted the fix/cisa-invalid-attr-display branch February 2, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Library: Create InstantSearch App Issues in create-instantsearch-app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants