Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(recommend): introduce Recommend widgets #6115

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

aymeric-giraudet
Copy link
Member

@aymeric-giraudet aymeric-giraudet commented Apr 4, 2024

This PR serves as the base branch for the Recommend feature.

FX-2788

Copy link

codesandbox-ci bot commented Apr 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b6037c0:

Sandbox Source
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-vue-instantsearch-default-theme Configuration

Base automatically changed from feat/helper-recommend-methods to master April 5, 2024 11:00
@aymeric-giraudet aymeric-giraudet force-pushed the feat/map-recommend-results branch 3 times, most recently from 2c1a3f9 to 69a9842 Compare April 5, 2024 13:05
@aymeric-giraudet aymeric-giraudet changed the title wip: map recommend results to widgets feat: map recommend results to widgets Apr 5, 2024
@aymeric-giraudet aymeric-giraudet marked this pull request as ready for review April 5, 2024 13:14
@raed667 raed667 added the Feature: Recommendations Providing recommendations of records or facets label Apr 8, 2024
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen assignees, is this PR ready for review? For me this would work, but might need adjustments to ensure numeric ids don't conflict easily when adding Recommend parameters and creating recommend results.

packages/algoliasearch-helper/index.d.ts Show resolved Hide resolved
@Haroenv
Copy link
Contributor

Haroenv commented Apr 18, 2024

would be good to rebase the first commits, and then "merge and rebase" the whole branch at the end (instead of squashing). Maybe it also should be marked as draft now until it's in a "ready to release" state?

@dhayab dhayab marked this pull request as draft April 18, 2024 16:24
aymeric-giraudet and others added 4 commits April 19, 2024 10:12
…r` component (#6114)

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…ent (#6129)

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
@dhayab dhayab force-pushed the feat/map-recommend-results branch from fa726da to 3121f7a Compare April 19, 2024 08:12
@Haroenv Haroenv changed the title feat: map recommend results to widgets feat: add recommend Apr 19, 2024
dhayab and others added 7 commits April 22, 2024 16:03
)


---------

Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
#6117)

---------

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
---------

Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…r` (#6143)

---------

Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@sarahdayan sarahdayan changed the title feat: add recommend feat(recommend): introduce Recommend widgets Apr 26, 2024
sarahdayan and others added 26 commits April 26, 2024 17:54
* feat(recommend): handle multiple objectIDs for one widget

* move flat to its own file with comment to remove it
…and widget (#6155)

---------

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
* feat(recommend): enable multiple objectIDs in connectors

* fix: merged recommendations should be in an object
* feat(recommend): introduce TrendingItems

FX-2853

* fix(recommend): correct type for generic base

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>

---------

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
* feat(recommend): add lookingSimilar widget

FX-2836

* test(recommend): correct initialisation

* fix: pass fallbackParameters

* test: ensure parameters get forwarded correctly
* feat(recommend): add LookingSimilar and useLookingSimilar

FX-2768

* test(cts): enable widget test
---------

Co-authored-by: Haroen Viaene <hello@haroen.me>
* refactor(ui-components): compute classNames only once

FX-2860

* fix name
#6201)

---------

Co-authored-by: Haroen Viaene <hello@haroen.me>
This is consistent with other widgets that don't have pagination like refinementList
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Recommendations Providing recommendations of records or facets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants