New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(recommend): introduce Recommend widgets #6115
base: master
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6037c0:
|
3d3bf1f
to
e041a2f
Compare
2c1a3f9
to
69a9842
Compare
69a9842
to
49f9efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen assignees, is this PR ready for review? For me this would work, but might need adjustments to ensure numeric ids don't conflict easily when adding Recommend parameters and creating recommend results.
would be good to rebase the first commits, and then "merge and rebase" the whole branch at the end (instead of squashing). Maybe it also should be marked as draft now until it's in a "ready to release" state? |
…r` component (#6114) Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…ent (#6129) Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
fa726da
to
3121f7a
Compare
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
#6117) --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
--------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
…r` (#6143) --------- Co-authored-by: Raed <raed.chammam@algolia.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
* feat(recommend): handle multiple objectIDs for one widget * move flat to its own file with comment to remove it
…and widget (#6155) --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
* feat(recommend): enable multiple objectIDs in connectors * fix: merged recommendations should be in an object
* feat(recommend): introduce TrendingItems FX-2853 * fix(recommend): correct type for generic base Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com> --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
* feat(recommend): add lookingSimilar widget FX-2836 * test(recommend): correct initialisation * fix: pass fallbackParameters * test: ensure parameters get forwarded correctly
* feat(recommend): add LookingSimilar and useLookingSimilar FX-2768 * test(cts): enable widget test
--------- Co-authored-by: Haroen Viaene <hello@haroen.me>
* refactor(ui-components): compute classNames only once FX-2860 * fix name
#6201) --------- Co-authored-by: Haroen Viaene <hello@haroen.me>
This is consistent with other widgets that don't have pagination like refinementList
This PR serves as the base branch for the Recommend feature.
FX-2788