fix(recommend): provide insights query parameters to recommend queries #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
added
the
Feature: Recommendations
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b057a43:
|
dhayab
changed the base branch from
feat/recommend-fbt-connector
to
feat/map-recommend-results
dhayab
changed the base branch from
feat/map-recommend-results
to
feat/recommend-fbt-connector
dhayab
force-pushed
the
feat/recommend-fbt-connector
branch
from
8498792
to
02de7c2
Compare
dhayab
force-pushed
the
fix/helper-recommend-insights
branch
from
a6c730c
to
e945286
Compare
raed667
reviewed
Apr 9, 2024
Comment on lines
+1638
to
+1640
| queryParameters: Object.assign(query.queryParameters || {}, { | ||
| clickAnalytics: searchState.clickAnalytics, | ||
| userToken: searchState.userToken, |
There was a problem hiding this comment.
Q: If the client passes queryParameters to the recommend widget, do they "lose" automatic event collection ?
There was a problem hiding this comment.
This is augmented thanks to Object.assign(), but it's a good idea to have a specific test for that, I'll add it to the PR.
|
Moving this back to draft for now (see discussion thread). |
Base automatically changed from
feat/recommend-fbt-connector
to
feat/map-recommend-results
April 23, 2024 07:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the recommend queries with
clickAnalyticsanduserTokento allow the API to properly enable event collection.Result
Recommendations are now returned with a
queryIDand events sent from Recommend widgets send this value when insights is enabled in InstantSearch.