feat(connectFrequentlyBoughtTogether): implement sendEvent #6128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b97118a:
|
dhayab
added
the
Feature: Recommendations
tkrugg
reviewed
Apr 9, 2024
| if (results === null || results === undefined) { | ||
| return { hits: [], widgetParams }; | ||
| return { hits: [], sendEvent, widgetParams }; |
There was a problem hiding this comment.
Hey Dhaya, as far as I know, queryID are only available on search query (not recommend queries).
I think the queryID mentioned here does not relate to recommend.
I would be in favour of not doing anything in particular regarding events yet. The current recommend libraries have the intention of adding it, but don't currently have it. I'll request changes for this, but let me know if I'm confused about this.
|
Moving this back to draft for now (see discussion thread). |
Base automatically changed from
feat/recommend-fbt-connector
to
feat/map-recommend-results
April 23, 2024 07:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR backports the changes in 8498792 to the relevant branch where it impacts the connector.