feat(recommend): introduce connectTrendingItems connector
#6169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
force-pushed
the
feat/recommend-ti-connector
branch
from
6ad723c
to
7721866
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b83dac2:
|
Base automatically changed from
feat/recommend-ti-ui-component
to
feat/map-recommend-results
April 29, 2024 15:30
dhayab
added
the
Feature: Recommendations
raed667
reviewed
Apr 29, 2024
packages/instantsearch.js/src/connectors/trending-items/connectTrendingItems.ts
Outdated
Show resolved
Hide resolved
Haroenv
reviewed
May 2, 2024
packages/instantsearch.js/src/connectors/trending-items/connectTrendingItems.ts
Show resolved
Hide resolved
| { act, skippedTests }: Required<TestOptions> | ||
| ) { | ||
| skippableDescribe('options', skippedTests, () => { | ||
| test('forwards parameters to the client', async () => { |
There was a problem hiding this comment.
there's no test that removing the widget removes the parameters too. Does that actually work, or does getParameters only work with future.cleanUpOnDispose?
There was a problem hiding this comment.
I looked into it and we missed handling this. There is support for removing recommend parameters at the helper level, but this is missing:
helper.removeXXX()expects string ids but we switched to numerical ids- the connector's
dispose()method receives the search state instead of the recommend state - no recommend connector calls
state.removeXXX()as of now
I'll create a task for tackling this properly.
Haroenv
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
connectTrendingItemsconnector and tests it in the connector common test suite.FX-2832