-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ARC22 and ARC28 interfaces for ABI contracts and methods #856
base: develop
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Just chiming in to say this would be nice to get in - it's preventing me from cleanly including ARC28 events in my tealscript contracts. The generated json blocks tests from being run because it doesn't match the schema defined in the sdk. |
@@ -77,6 +82,7 @@ export class ABIMethod { | |||
}>; | |||
|
|||
public readonly returns: { type: ABIReturnType; description?: string }; | |||
public readonly events: ARC28Event[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still missing readonly
Also it looks like this failing in cucumber tests:
Perhaps when converting to JSON, if no events are present, that field should be omitted from the result? Since these tests run on every SDK, they're a bit difficult to deal with. |
Adds ARC28 (events) and ARC22 (readonly) to ABI-related interfaces