fix: operator.update, columns in where cant be updated #27

sunfuze · 2017-07-18T09:39:32Z

mention-bot · 2017-07-18T09:39:34Z

@sunfuze, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @dead-horse and @csbun to be potential reviewers.

fengmk2 · 2017-07-18T09:47:01Z

lib/operator.js

@@ -154,15 +154,13 @@ proto.update = function* (table, row, options) {
    options.where = {
      id: row.id,
    };
+    [].splice.call(options.columns, options.columns.indexOf('id'), 1);


这段代码好奇怪。。。

请加上测试用例辅助说明问题

codecov-io · 2017-07-18T11:27:54Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7cb4e75). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #27   +/-   ##
=========================================
  Coverage          ?   98.92%           
=========================================
  Files             ?        6           
  Lines             ?      278           
  Branches          ?       40           
=========================================
  Hits              ?      275           
  Misses            ?        3           
  Partials          ?        0

Impacted Files	Coverage Δ
lib/operator.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb4e75...089fa9b. Read the comment docs.

sunfuze · 2017-07-18T12:11:28Z

db.update('table', { field1: 'abc', field2: 'efg' }, {
  where: { field1: 'a', id: 1 }
})`

原来上面这种情况，是不会更新 field1的。

db.update('table', { id: 1, field1: 'abc' })

上面的代码生成的 sql 不应该有 'SET id = 1' 的内容。

fengmk2 reviewed Jul 18, 2017

View reviewed changes

fix: operator.update, columns in where cant be updated

089fa9b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: operator.update, columns in where cant be updated #27

fix: operator.update, columns in where cant be updated #27

sunfuze commented Jul 18, 2017 •

edited

mention-bot commented Jul 18, 2017

fengmk2 Jul 18, 2017

codecov-io commented Jul 18, 2017 •

edited

sunfuze commented Jul 18, 2017

fix: operator.update, columns in where cant be updated #27

Are you sure you want to change the base?

fix: operator.update, columns in where cant be updated #27

Conversation

sunfuze commented Jul 18, 2017 • edited

mention-bot commented Jul 18, 2017

fengmk2 Jul 18, 2017

Choose a reason for hiding this comment

codecov-io commented Jul 18, 2017 • edited

Codecov Report

sunfuze commented Jul 18, 2017

sunfuze commented Jul 18, 2017 •

edited

codecov-io commented Jul 18, 2017 •

edited