Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dropdown): ts & docs &test #4699

Conversation

woshilaoge
Copy link

@woshilaoge woshilaoge commented Jan 4, 2024

close #4583

Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. master有更新,合并后执行类型检查,根据错误调整下代码
  2. eslint-disabled 都要去除

components/dropdown/types.ts Outdated Show resolved Hide resolved
components/dropdown/types.ts Outdated Show resolved Hide resolved
components/dropdown/types.ts Outdated Show resolved Hide resolved
components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
components/dropdown/dropdown.tsx Outdated Show resolved Hide resolved
components/dropdown/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
Copy link

你好,该 pr 已 30 天没有活动,因此被标记为 stale,如果之后的 7 天仍然没有活动,该 pr 将被自动关闭

@github-actions github-actions bot added Stale not active for a lone time and removed Stale not active for a lone time labels Feb 24, 2024
components/dropdown/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/dropdown/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/dropdown/__tests__/index-spec.tsx Outdated Show resolved Hide resolved
components/dropdown/__tests__/index-spec.tsx Show resolved Hide resolved
components/dropdown/types.ts Outdated Show resolved Hide resolved
components/dropdown/types.ts Show resolved Hide resolved
components/dropdown/__tests__/a11y-spec.tsx Show resolved Hide resolved
@YSMJ1994
Copy link
Contributor

因为这个组件 api 大量继承了 Overlay.Popup 组件的 api ,从可读性来看全部使用 Popup['xxx'] 的方式展示文档不太友好,起不到指导作用,且 overlay 组件目前还未完成改造,很多类型不太正确,直接复制过来也不合适,先 hold 吧,等 overlay 改造完成后再调整 api 类型定义

@eternalsky eternalsky changed the base branch from master to refactor/dropdown May 30, 2024 02:31
@eternalsky
Copy link
Contributor

由于人员变动,先把 pr merge,后续再进一步处理。

@eternalsky eternalsky merged commit 18117d9 into alibaba-fusion:refactor/dropdown May 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

【Technical upgrade】Dropdown
3 participants