-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Dropdown): ts & docs &test #4699
Merged
eternalsky
merged 5 commits into
alibaba-fusion:refactor/dropdown
from
woshilaoge:chore/xiaoxian-dropdown2
May 30, 2024
Merged
chore(Dropdown): ts & docs &test #4699
eternalsky
merged 5 commits into
alibaba-fusion:refactor/dropdown
from
woshilaoge:chore/xiaoxian-dropdown2
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YSMJ1994
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- master有更新,合并后执行类型检查,根据错误调整下代码
- eslint-disabled 都要去除
你好,该 pr 已 30 天没有活动,因此被标记为 stale,如果之后的 7 天仍然没有活动,该 pr 将被自动关闭 |
github-actions
bot
added
Stale
not active for a lone time
and removed
Stale
not active for a lone time
labels
Feb 24, 2024
YSMJ1994
requested changes
Mar 14, 2024
因为这个组件 api 大量继承了 Overlay.Popup 组件的 api ,从可读性来看全部使用 |
由于人员变动,先把 pr merge,后续再进一步处理。 |
eternalsky
merged commit May 30, 2024
18117d9
into
alibaba-fusion:refactor/dropdown
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4583