Fix issue 4593 #4807
Open
Fix issue 4593 #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Yuchaocheng
force-pushed
the
fix-issue-4593
branch
2 times, most recently
from
0114ee1
to
88d6f6d
Compare
eternalsky
requested changes
May 14, 2024
|
|
||
| if (typeof config === 'string' || React.isValidElement(config)) { | ||
| newConfig.title = config; | ||
| } else if (obj.typeOf(config) === 'Object') { | ||
| newConfig = { ...config }; | ||
| newConfig = { ...(config as MessageQuickProps) }; |
| @@ -18,6 +18,8 @@ const MessageProvider = ConfigProvider.config(Message, { | |||
| }); | |||
|
|
|||
| export default MessageProvider; | |||
| export type { MessageProps, MessageQuickProps } from './types'; | |||
| export type ContextMessage = typeof toast; | |||
There was a problem hiding this comment.
这个类型的导出感觉没有必要，typeof 是很容易得的。
Yuchaocheng
force-pushed
the
fix-issue-4593
branch
from
88d6f6d
to
5b19c57
Compare
eternalsky
reviewed
May 30, 2024
| }, | ||
| afterClose, | ||
| }); | ||
| delay(200).then(() => { |
There was a problem hiding this comment.
delay 在这里没有意义，get 本身就可以等待四秒
|
|
||
| setTimeout(() => { | ||
| assert(document.querySelector('.next-overlay-wrapper .next-message.next-message') !== null); | ||
| delay(500).then(() => { |
There was a problem hiding this comment.
此处同上，所有 delay 都没必要加入，不再赘述，如果哪里必须要加 delay，可以找我讨论
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| type AnyProps = any; | ||
| type ConfigMask = InstanceType<typeof NewMask> | null; |
There was a problem hiding this comment.
ConfigMask 里感觉不应该包含 null，null 应该是在下面和 ConfigMask 并列
eternalsky
requested changes
May 30, 2024
|
|
||
| ```js |
eternalsky
requested changes
May 30, 2024
| animation: PropTypes.bool, | ||
| locale: PropTypes.object, | ||
| rtl: PropTypes.bool, | ||
| }; | ||
| static config: (config: MessageConfig) => void; |
There was a problem hiding this comment.
这四个类方法还是看不懂，如果是外面赋值的，那应该都是放在 assignSubComponents 里的，如果不是，这里又指给了类型没有实现。另外 open 下面那三个确定一下是成员方法还是类方法？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4593