refactor(interactive): Add more detail tracer for query handler #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
changed the title
siyuan0322
reviewed
May 13, 2024
| opentelemetry::nostd::unique_ptr<opentelemetry::metrics::Counter<uint64_t>> | ||
| total_counter_; | ||
| opentelemetry::nostd::unique_ptr<opentelemetry::metrics::Counter<uint64_t>> | ||
| success_counter_; |
There was a problem hiding this comment.
Use a total_counter and append label to denote success. This would reduce the amount of data to export.
siyuan0322
reviewed
May 13, 2024
| success_counter_->Add(1); | ||
| outer_span->End(); | ||
| auto end_ts = gs::GetCurrentTimeStamp(); | ||
| std::map<std::string, std::string> labels = {{"key", "value"}}; |
There was a problem hiding this comment.
What's this dummy labels for?
siyuan0322
approved these changes
May 13, 2024
shirly121
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subspans for
adhoc_querytracer, and add tracer forstored_procedure_query.Add metrics for adhoc and procedure queries