Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复当FileRefreshableDataSource文件为空时读取异常 #3252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

genjigjj
Copy link

Describe what this PR does / why we need it

在使用FileRefreshableDataSource作为规则数据源时,发现如果初始化空规则文件会导致StringIndexOutOfBoundsException异常

Does this pull request fix one issue?

Describe how you did it

判断规则文件是否有数据

Describe how to verify it

加载空的规则文件看是否有异常打印

Special notes for reviews

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


郭佳俊 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LearningGp
Copy link
Collaborator

The CLA needs to be signed before the code is merged. ✒️

LearningGp

This comment was marked as resolved.

Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp added kind/question Category issues related to questions or problems area/data-source Issues or PRs related to data-source extension labels Dec 24, 2023
@sczyh30 sczyh30 added kind/enhancement Category issues or prs related to enhancement. and removed kind/question Category issues related to questions or problems labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-source Issues or PRs related to data-source extension kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants