Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DefaultBlockRequestHandler Adapt to SpringBoot 3 #3379

Open
wants to merge 3 commits into
base: 1.8
Choose a base branch
from

Conversation

cxhello
Copy link

@cxhello cxhello commented Apr 19, 2024

Describe what this PR does / why we need it

DefaultBlockRequestHandler Adapt to SpringBoot 3

Does this pull request fix one issue?

Closes #3298

Describe how you did it

org.springframework.web.reactive.function.server.ServerResponse#status(org.springframework.http.HttpStatus) method was modified in springboot 3 to org.springframework.web.reactive.function.server.ServerResponse#status(org.springframework.http.HttpStatusCode)

but Both versions are available org.springframework.web.reactive.function.server.ServerResponse#status(int) method. so i modified it.

Describe how to verify it

alibaba/spring-cloud-alibaba#3688

Special notes for reviews

@robberphex
Copy link
Collaborator

Could you mind add unit test for this case? Which means, before this PR gets merged, the test will fail. The test is very helpful for long-runt maintains, and can prevent similar errors.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 45.92%. Comparing base (cd02b1d) to head (477e25a).

❗ Current head 477e25a differs from pull request most recent head 95cc1f3. Consider uploading reports for the commit 95cc1f3 to get more accurate results

Files Patch % Lines
...ateway/sc/callback/DefaultBlockRequestHandler.java 0.00% 2 Missing ⚠️
...g/webflux/callback/DefaultBlockRequestHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.8    #3379      +/-   ##
============================================
+ Coverage     45.89%   45.92%   +0.03%     
- Complexity     2145     2147       +2     
============================================
  Files           431      431              
  Lines         12903    12903              
  Branches       1727     1727              
============================================
+ Hits           5922     5926       +4     
+ Misses         6279     6277       -2     
+ Partials        702      700       -2     
Components Coverage Δ
sentinel-adapter 43.22% <0.00%> (ø)
sentinel-cluster 23.71% <ø> (ø)
sentinel-core 59.64% <ø> (+0.01%) ⬆️
sentinel-extension 46.32% <ø> (+0.13%) ⬆️
sentinel-logging 54.54% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxhello
Copy link
Author

cxhello commented Apr 22, 2024

@robberphex added DefaultBlockRequestHandler unit test.

@cxhello
Copy link
Author

cxhello commented May 28, 2024

@robberphex Are you still planning to process this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] NoSuchMethodError: 'org.springframework.web.reactive.function.server.ServerResponse$BodyBuilder
2 participants