Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PathSelector): problem about PathSelector which gets the wrong ArrayDepth #292

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheYuuu
Copy link

@TheYuuu TheYuuu commented May 8, 2022

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from main.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for designable-fusion failed.

Name Link
🔨 Latest commit 7093770
🔍 Latest deploy log https://app.netlify.com/sites/designable-fusion/deploys/62777e3bc47dae0008dd607a

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


罗瑜 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented May 8, 2022

Deploy Preview for designable-antd ready!

Name Link
🔨 Latest commit 7093770
🔍 Latest deploy log https://app.netlify.com/sites/designable-antd/deploys/62777e3bb060f80008639ad3
😎 Deploy Preview https://deploy-preview-292--designable-antd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@TheYuuu
Copy link
Author

TheYuuu commented May 8, 2022

when repeat dragging arrayTable into arrayTable, and the name of ArrayColumn is the same as the component inside the ArrayColumn, the PathSelect will render these repeatedly named components multiple times,as the value of the node is composed of array depth, but the depth calculation is not right

@TheYuuu
Copy link
Author

TheYuuu commented May 8, 2022

9d4b5c29-2d5a-4677-96ab-7e2164908b4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants