fix heartbeat miss filling hostname #1277

liangry · 2023-12-21T12:19:47Z

agent should report hostname to config server
uuid is not helpful to identify agent. ip, pid and time is enough

2. uuid is not helpful to identify agent. ip, pid and time is enough

yyuuttaaoo · 2023-12-22T11:45:29Z

core/config_manager/ConfigManagerBase.cpp

@@ -1312,7 +1312,7 @@ ConfigManagerBase::ConfigManagerBase() {
    CorrectionLogtailSysConfDir(); // first create dir then rewrite system-uuid file in GetSystemUUID
    // use a thread to get uuid, work around for CalculateDmiUUID hang
    // mUUID = CalculateDmiUUID();
-    mInstanceId = CalculateRandomUUID() + "_" + LogFileProfiler::mIpAddr + "_" + ToString(time(NULL));
+    mInstanceId = LogFileProfiler::mIpAddr + "_" + ToString(getpid()) + "_" + ToString(time(NULL));


这个不太建议改，pid可能复用，多租环境下也不能确保ip+pid的唯一性

现在是IP+PID+时间戳，有其它更好方案吗？UUID真是百无一用

也不能这么说，uuid就是uuid，你不能说一个id就是没用的，他的作用就是保持唯一性。如果是一些重要信息的的encode或者signature那么肯定会更好。

它不仅是一个 ID，还是一个数据库主键，我们采集集群已经拥有超过四位数的 Agent 了，使用 UUID 作为主键会有明显的负作用，我相信绝大多数情况下 IP+PID+时间戳足够了，要是真的有特殊情况不接受，起码也应该让用户有选择权去决定 Agent 的主键选择

1. since mInstanceId is already applied, use a new member mAgentId instead 2. in practise, ip + time + pid is better than ip + pid + time

fix: 1. agent should report hostname to config server

d23f741

2. uuid is not helpful to identify agent. ip, pid and time is enough

yyuuttaaoo requested a review from Takuka0311 December 22, 2023 08:28

yyuuttaaoo reviewed Dec 22, 2023

View reviewed changes

fix: set agent id

d6db707

1. since mInstanceId is already applied, use a new member mAgentId instead 2. in practise, ip + time + pid is better than ip + pid + time

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix heartbeat miss filling hostname #1277

fix heartbeat miss filling hostname #1277

liangry commented Dec 21, 2023

yyuuttaaoo Dec 22, 2023

liangry Dec 23, 2023

yyuuttaaoo Dec 24, 2023

liangry Dec 25, 2023

fix heartbeat miss filling hostname #1277

Are you sure you want to change the base?

fix heartbeat miss filling hostname #1277

Conversation

liangry commented Dec 21, 2023

yyuuttaaoo Dec 22, 2023

Choose a reason for hiding this comment

liangry Dec 23, 2023

Choose a reason for hiding this comment

yyuuttaaoo Dec 24, 2023

Choose a reason for hiding this comment

liangry Dec 25, 2023

Choose a reason for hiding this comment