Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: don't load prebuilt "imagenet" weights when inferencing #372

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

CandyQiu
Copy link
Contributor

change imagenet weights

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CandyQiu Thanks for your contribution, may I ask you to sign our CLA firstly, and there are some unneeded changes which should be reverted :)

boa.kwargs({
activation: 'relu'
})
)(output);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change may not be needed.

inputs: model.input,
outputs: outputs
})
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

loss: loss,
metrics: metrics
})
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@yorkie yorkie changed the title Fix issue #324 plugin: don't load prebuilt "imagenet" weights when inferencing Jul 27, 2020
@yorkie yorkie added the plugin Pipcook plugin addition, bug report and changes label Jul 27, 2020
@yorkie
Copy link
Member

yorkie commented Jul 27, 2020

Because of the bug of eslint-plugin-react@7.20.4, may I ask you to rebase your branch on master again, we have fixed that at #375 and it gets merged on the master branch already.

@rickycao-qy
Copy link
Collaborator

@CandyQiu Could you format the codes as normal and rebase the master as we discussed before, thx

@rickycao-qy
Copy link
Collaborator

LGTM

Copy link
Member

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycao-qy rickycao-qy merged commit 729700f into alibaba:master Aug 4, 2020
}
};
return result;
};

export default resnetModelDefine;
export default resnetModelDefine;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need an EOL here?

Suggested change
export default resnetModelDefine;
export default resnetModelDefine;

gindis pushed a commit to gindis/pipcook that referenced this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin Pipcook plugin addition, bug report and changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

model define's plugins based on tensorflow do not need to load imagenet weights when in inference mode
5 participants