Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update args of golangci-lint in ci.yml #535

Merged
merged 1 commit into from Jun 26, 2023
Merged

Conversation

jnan806
Copy link
Contributor

@jnan806 jnan806 commented Jun 14, 2023

Describe what this PR does / why we need it

update args of golangci-lint in ci.yml according to official guides

Does this pull request fix one issue?

Describe how you did it

according to comment of golangci/golangci-lint-action#618 (comment)
relation pr golangci/golangci-lint-action#769

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added the area/ci Issues or PRs related to CI label Jun 25, 2023
@sczyh30
Copy link
Member

sczyh30 commented Jun 25, 2023

Could you please sync with the latest master branch? We've fixed other CI failures.

Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (e2f2f73) 53.17% compared to head (6c33f47) 53.17%.

❗ Current head 6c33f47 differs from pull request most recent head aba5c14. Consider uploading reports for the commit aba5c14 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   53.17%   53.17%           
=======================================
  Files          91       91           
  Lines        5894     5894           
=======================================
  Hits         3134     3134           
  Misses       2413     2413           
  Partials      347      347           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jnan806
Copy link
Contributor Author

jnan806 commented Jun 25, 2023

Could you please sync with the latest master branch? We've fixed other CI failures.

done

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 0807185 into alibaba:master Jun 26, 2023
5 checks passed
@sczyh30
Copy link
Member

sczyh30 commented Jun 26, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants