Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new features: add distributed scheduling support. #3732

Open
wants to merge 5 commits into
base: 2023.x
Choose a base branch
from
Open

new features: add distributed scheduling support. #3732

wants to merge 5 commits into from

Conversation

yaohuitc
Copy link

new features: add distributed scheduling support.

chickenlj
chickenlj approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yuluo-yx
yuluo-yx reviewed May 15, 2024
View reviewed changes
...loud-scheduling-example/src/main/java/com/alibaba/cloud/examples/schedule/job/SimpleJob.java Outdated Show resolved Hide resolved
...baba-examples/spring-cloud-scheduling-example/src/main/resources/application-schedulerx.yaml Outdated Show resolved Hide resolved
...g-cloud-alibaba-examples/spring-cloud-scheduling-example/src/main/resources/application.yaml Outdated Show resolved Hide resolved
...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved
...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved
...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved
...ba-schedulerx/src/main/java/com/alibaba/cloud/scheduling/shedlock/ShedLockAutoConfigure.java Show resolved Hide resolved
...tarters/spring-cloud-starter-alibaba-schedulerx/src/main/resources/META-INF/spring.factories Outdated Show resolved Hide resolved
...n/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports Outdated Show resolved Hide resolved
.../spring-cloud-starter-alibaba-schedulerx/src/main/resources/shedlock/schema/schema-mysql.sql Outdated Show resolved Hide resolved
@yuluo-yx yuluo-yx added kind/enhancement area/scheduling distributed scheduling labels May 15, 2024
yaohuitc
yaohuitc commented May 16, 2024
View reviewed changes
Copy link
Author

@yaohuitc yaohuitc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.../spring-cloud-starter-alibaba-schedulerx/src/main/resources/shedlock/schema/schema-mysql.sql Outdated Show resolved Hide resolved
spring-cloud-alibaba-examples/spring-cloud-scheduling-example/pom.xml Outdated Show resolved Hide resolved
...cheduling-example/src/main/java/com/alibaba/cloud/examples/schedule/ScheduleApplication.java Outdated Show resolved Hide resolved
...baba-examples/spring-cloud-scheduling-example/src/main/resources/application-schedulerx.yaml Outdated Show resolved Hide resolved
...g-cloud-alibaba-examples/spring-cloud-scheduling-example/src/main/resources/application.yaml Outdated Show resolved Hide resolved
...schedulerx/src/main/java/com/alibaba/cloud/scheduling/schedulerx/service/JobSyncService.java Outdated Show resolved Hide resolved
...ba-schedulerx/src/main/java/com/alibaba/cloud/scheduling/shedlock/ShedLockAutoConfigure.java Show resolved Hide resolved
...tarters/spring-cloud-starter-alibaba-schedulerx/src/main/resources/META-INF/spring.factories Outdated Show resolved Hide resolved
...n/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports Outdated Show resolved Hide resolved
...loud-scheduling-example/src/main/java/com/alibaba/cloud/examples/schedule/job/SimpleJob.java Outdated Show resolved Hide resolved
@yaohuitc yaohuitc requested a review from yuluo-yx May 16, 2024 07:14
@yuluo-yx
Copy link
Collaborator

hi @yaohuitc pls fix ci, before commit, you can run mvn clean install -Dmaven.test.sip=true to check code style. or run mvn clean install to sca.

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented May 16, 2024 •
edited

@yaohuitc Can you write readme.md files? I don't konw how to config application.yml and other configuration.I cann't run example on my local machine.

yuluo-yx
yuluo-yx reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comment.

spring-cloud-alibaba-starters/spring-cloud-starter-alibaba-schedulerx/pom.xml Outdated Show resolved Hide resolved
@yaohuitc yaohuitc closed this May 17, 2024
@yaohuitc yaohuitc reopened this May 17, 2024
@yaohuitc
Copy link
Author

@yaohuitc Can you write readme.md files? I don't konw how to config application.yml and other configuration.I cann't run example on my local machine.

can you share some error information when you're running the example

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented May 17, 2024 •
edited 

Public Key Retrieval is not allowed

add allowPublicKeyRetrieval=true

java.sql.SQLException: Access denied for user 'root'@'localhost' (using password: YES)
java.sql.SQLSyntaxErrorException: Unknown database 'testdb'

Since there is no readme documentation, I don't know what to configure or change, and there is no sql script in the example

@yaohuitc
Copy link
Author 

Public Key Retrieval is not allowed

add allowPublicKeyRetrieval=true

java.sql.SQLException: Access denied for user 'root'@'localhost' (using password: YES)
java.sql.SQLSyntaxErrorException: Unknown database 'testdb'

Since there is no readme documentation, I don't know what to configure or change, and there is no sql script in the example

OK, 👌

yuluo-yx
yuluo-yx approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tks @yaohuitc

@yuluo-yx
Copy link
Collaborator

pls resolve conflicts, We will discuss this at the next weekly meeting and merge afterward.

@yaohuitc
Merge branch '2023.x' of https://github.com/alibaba/spring-cloud-alibaba
eda5a1c 
 into 2023.x

� Conflicts:
�	spring-cloud-alibaba-examples/pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj chickenlj approved these changes

@yuluo-yx yuluo-yx yuluo-yx approved these changes

Assignees

@yaohuitc yaohuitc

Labels
area/scheduling distributed scheduling kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yaohuitc @yuluo-yx @chickenlj