Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support loading agent dynamically #170

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tjstqq
Copy link

@tjstqq tjstqq commented Apr 2, 2020

according to Java Agent and Instrumentation APIs,add entry "agentmain" and "Agent-Class" config in MANIFEST

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2020

CLA assistant check
All committers have signed the CLA.

pom.xml Outdated
<source>1.6</source>
<target>1.6</target>
<source>1.7</source>
<target>1.7</target>
<encoding>${project.build.sourceEncoding}</encoding>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TTL support jdk 1.6, so do not modify the source/target level please.

@tjstqq tjstqq closed this Apr 2, 2020
@tjstqq tjstqq reopened this Apr 2, 2020
@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #170   +/-   ##
=========================================
  Coverage     74.68%   74.68%           
  Complexity      133      133           
=========================================
  Files            15       15           
  Lines           470      470           
  Branches         52       52           
=========================================
  Hits            351      351           
  Misses          104      104           
  Partials         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c03e4...fb47e05. Read the comment docs.

@zscgrhg
Copy link

zscgrhg commented Apr 15, 2020

我发现动态加载有时候会失败,ttl值没有正常生效。但是又找不到规律

@tjstqq
Copy link
Author

tjstqq commented Apr 16, 2020

我发现动态加载有时候会失败,ttl值没有正常生效。但是又找不到规律

能否把调用的情况详细贴出来,方便分析下

@zscgrhg
Copy link

zscgrhg commented May 1, 2020

我发现动态加载有时候会失败,ttl值没有正常生效。但是又找不到规律

能否把调用的情况详细贴出来,方便分析下

暂时解决这个问题了,刚开始我是在junit rule 里面加载agent,这样会出现随机的结果,有时候生效,有时候无效,后面我改成在junit runner静态初始化的时候加载,就OK了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants