Merge pull request #330 from sejin-P/ZADD-LT-default-value

fix; check key existence when applying LT GT option to ZADD
alicebob · Jun 13, 2023 · f507fa8 · f507fa8
2 parents df41945 + b0d3aee
commit f507fa8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/cmd_sorted_set.go b/cmd_sorted_set.go
@@ -163,17 +163,18 @@ outer:
 
 		res := 0
 		for member, score := range elems {
-			if opts.nx && db.ssetExists(opts.key, member) {
+			exists := db.ssetExists(opts.key, member)
+			if opts.nx && exists {
 				continue
 			}
-			if opts.xx && !db.ssetExists(opts.key, member) {
+			if opts.xx && !exists {
 				continue
 			}
 			old := db.ssetScore(opts.key, member)
-			if opts.gt && score <= old {
+			if opts.gt && exists && score <= old {
 				continue
 			}
-			if opts.lt && score >= old {
+			if opts.lt && exists && score >= old {
 				continue
 			}
 			if db.ssetAdd(opts.key, score, member) {

diff --git a/cmd_sorted_set_test.go b/cmd_sorted_set_test.go
@@ -236,6 +236,13 @@ func TestSortedSetAdd(t *testing.T) {
 		)
 	}
 
+	t.Run("LT and GT options", func(t *testing.T) {
+		must1(t, c, "ZADD", "zlt", "LT", "1", "one")
+		must0(t, c, "ZADD", "zlt", "LT", "2", "one")
+		must1(t, c, "ZADD", "zgt", "GT", "-1", "one")
+		must0(t, c, "ZADD", "zgt", "GT", "-2", "one")
+	})
+
 	t.Run("errors", func(t *testing.T) {
 		// Wrong type of key
 		mustOK(t, c, "SET", "str", "value")