Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HRANDFIELD implementation #351

Merged
merged 4 commits into from
Dec 12, 2023
Merged

HRANDFIELD implementation #351

merged 4 commits into from
Dec 12, 2023

Conversation

sejin-P
Copy link
Contributor

@sejin-P sejin-P commented Dec 4, 2023 •
edited

Implementation of HRANDFIELD

@alicebob
Copy link
Owner

alicebob commented Dec 4, 2023

Thanks, looks good! Would it be possible to add a test in ./integration/ ? If not, also no problem.

Will have a better look in a few days.

@sejin-P
Copy link
Contributor Author

sejin-P commented Dec 4, 2023

@alicebob I added integration test case, but it had limit because testing random is pretty tricky.

@alicebob
Copy link
Owner

alicebob commented Dec 4, 2023 via email

@alicebob alicebob merged commit 794a09d into alicebob:master Dec 12, 2023
4 checks passed
@alicebob
Copy link
Owner

Very nice. Merged, thanks!

@sejin-P sejin-P deleted the HRANDFIELD branch December 13, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sejin-P @alicebob