lib: do not update default client configuration

aliyun · Mar 26, 2024 · ea6c47e · ea6c47e
1 parent 44a8a7b
commit ea6c47e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/sdk/auth/credentials/provider/instance_credentials.go b/sdk/auth/credentials/provider/instance_credentials.go
@@ -68,8 +68,9 @@ func (p *InstanceCredentialsProvider) Resolve() (auth.Credential, error) {
 }
 
 func get(url string) (status int, content []byte, err error) {
-	httpClient := http.DefaultClient
-	httpClient.Timeout = 1 * time.Second
+	httpClient := &http.Client{
+		Timeout: 1 * time.Second,
+	}
 	resp, err := httpClient.Get(url)
 	if err != nil {
 		return

diff --git a/sdk/auth/credentials/provider/provider_chain.go b/sdk/auth/credentials/provider/provider_chain.go
@@ -24,9 +24,12 @@ func (p *ProviderChain) Resolve() (auth.Credential, error) {
 		creds, err := provider.Resolve()
 		if err != nil {
 			return nil, err
-		} else if err == nil && creds == nil {
+		}
+
+		if creds == nil {
 			continue
 		}
+
 		return creds, err
 	}
 	return nil, errors.New("No credential found")