Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:在某些情况下httpResponse没有关闭(in some special case,httpResponse not close) #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tangwc
Copy link

@tangwc tangwc commented Apr 3, 2023

DoActionWithSigner,if AutoRetry may cause httpResponse not close. the httpResponse close logic is outside the for loop in responses.Unmarshal function. if AutoRetry open and response no err but statusCode wrong.in this cause httpResponse not close. 1、if client.buildRequestWithSigner has err,it will return then cause the problem 2、if continue,httpResponse will redefined then cause the problem so add defer httpResponse.Body.Close() in for loop to solve it.

DoActionWithSigner,自动重试时有可能造成没有关闭链接的问题。
当前逻辑,代码仅在for循环之外的responses.Unmarshal中处理了httpResponse的close。但是在for循环中的最后一个逻辑-自动重试会有问题。 如果AutoRetry开启,返回正常,但是返回的statusCode大于设定值,会进入自动重试逻辑。这个重试逻辑里有两种可能。 1、client.buildRequestWithSigner时报错,会return掉,导致httpResponse没有关闭。 2、continue时,httpResponse会重新赋值,导致老的httpResponse没有关闭。

DoActionWithSigner,if AutoRetry may cause httpResponse not close.
the httpResponse close logic is outside the for loop in responses.Unmarshal function.
if AutoRetry open and response no err but statusCode wrong.in this cause httpResponse not close.
1、if client.buildRequestWithSigner has err,it will return then cause the problem
2、if continue,httpResponse will redefined then cause the problem
so add defer httpResponse.Body.Close() in for loop to solve it.

DoActionWithSigner,自动重试时有可能造成没有关闭链接的问题。
当前逻辑,代码仅在for循环之外的responses.Unmarshal中处理了httpResponse的close。但是在for循环中的最后一个逻辑-自动重试会有问题。
如果AutoRetry开启,返回正常,但是返回的statusCode大于设定值,会进入自动重试逻辑。这个重试逻辑里有两种可能。
1、client.buildRequestWithSigner时报错,会return掉,导致httpResponse没有关闭。
2、continue时,httpResponse会重新赋值,导致老的httpResponse没有关闭。
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


tangweichen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yndu13
Copy link
Contributor

yndu13 commented Jun 8, 2023

非常感谢提供pr,确实有这个问题,代码看起来也没问题。我们需要再加个测试验证下。

@@ -692,6 +692,7 @@ func (client *Client) DoActionWithSigner(request requests.AcsRequest, response r
return
}
}
defer httpResponse.Body.Close()
Copy link
Contributor

@yndu13 yndu13 Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当出现服务不存在等报错时,这里会有中断,辛苦加个判断:
if httpResponse != nil && httpResponse.Body != nil {
defer httpResponse.Body.Close()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants