Don't use %#v to format error #7070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find alicloud -name '*.go' | xargs sed -E -e '/fmt\.Errorf\(/ s/%#v.?", (.*)err\)$/%w", \1err)/' -i ''
%#v is not suitable for print error. It is unreadable, and missing important information.
For example, before (with %#v):
&url.Error{Op:"Post", URL:"https://...", Err:(*net.OpError)(0x14002fa4000)}
after (in this PR, with %w):
Post "https://...": dial tcp: lookup example.com: no such host
find alicloud -name '*.go' | xargs sed -E -e 's/%#v.?", (.*)err\)$/%v", \1err)/' -i '' the same as the previous commit, for cases that not use fmt.Errorf()
|
|
the same as the above commits, but changed manually, with the help of: golangci-lint run --disable-all --enable errorlint --max-same-issues 100 ./alicloud/...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%#v is not suitable for print error. It is unreadable, and missing important information.
For example, before (with %#v):
after (in this PR, with %w or %v):