Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Explicitly set dtype=object when generating permutations #534

Merged
merged 3 commits into from Dec 20, 2022
Merged

[MRG] Explicitly set dtype=object when generating permutations #534

merged 3 commits into from Dec 20, 2022

Conversation

aaronreidsmith
Copy link
Member

@aaronreidsmith aaronreidsmith commented Dec 20, 2022 •
edited

Description

Our nightly build is failing due to this expired deprecation. I think explicitly calling dtype='object' should fix it

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aaronreidsmith aaronreidsmith marked this pull request as ready for review December 20, 2022 18:43
@tgsmith61591 tgsmith61591 merged commit 587c380 into master Dec 20, 2022
@tgsmith61591 tgsmith61591 deleted the numpy-regression branch December 20, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgsmith61591 tgsmith61591 tgsmith61591 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronreidsmith @tgsmith61591