feat: commit conventions #343

Berkmann18 · 2021-01-18T20:35:58Z

Updated version of #200

vercel · 2021-01-18T20:36:00Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/all-contributors-app/app/8yb7x41wc
✅ Preview: https://app-git-commit-conv.all-contributors-app.vercel.app

[Deployment for d84a210 failed]

gr2m · 2021-01-18T20:43:51Z

@Berkmann18 if you want to test the deployment for this PR, you can update the webhook URL to https://app-git-commit-conv.all-contributors-app.vercel.app/api/github/webhooks at https://github.com/organizations/all-contributors/settings/apps/all-contributors-preview#integration_hook_attributes_active

Berkmann18 · 2021-01-18T20:46:58Z

The link 404s for me :/.

gr2m · 2021-01-18T20:57:15Z

try again please

…onvention used

It would need to be aware of the configuration used to test for the other conventions

gr2m · 2021-10-20T03:58:13Z

@Berkmann18 did you have a chance to see if it works? Can you rebase your PR on the latest changes?

Berkmann18 · 2021-11-29T22:34:24Z

@gr2m Not since I last worked on this which wasn't a high priority thing.

tenshiAMD

@Berkmann18 Hi, please rebase to master branch first so we can proceed with this PR. Thanks!

tenshiAMD · 2022-09-06T19:41:01Z

@gr2m Not since I last worked on this which wasn't a high priority thing.

@Berkmann18 Can I help check this one?

vercel · 2022-09-06T20:35:42Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
app	✅ Ready (Inspect)	Visit Preview	Sep 12, 2022 at 7:22PM (UTC)

Berkmann18 · 2022-09-06T20:36:42Z

@tenshiAMD I've resolved the conflict. And yeah, you can help check that.

codecov · 2022-09-12T01:46:53Z

Codecov Report

Base: 99.21% // Head: 99.22% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7da26e6) compared to base (98a3a02).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7da26e6 differs from pull request most recent head 70fe001. Consider uploading reports for the commit 70fe001 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   99.21%   99.22%   +0.01%     
==========================================
  Files          15       15              
  Lines         381      387       +6     
  Branches       46       47       +1     
==========================================
+ Hits          378      384       +6     
  Misses          3        3

Impacted Files	Coverage Δ
lib/add-contributor.js	`100.00% <100.00%> (ø)`
lib/modules/config.js	`95.52% <100.00%> (+0.13%)`	⬆️
lib/modules/repository.js	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tenshiAMD · 2022-09-12T01:48:00Z

@Berkmann18 if you want to test the deployment for this PR, you can update the webhook URL to https://app-git-commit-conv.all-contributors-app.vercel.app/api/github/webhooks at github.com/organizations/all-contributors/settings/apps/all-contributors-preview#integration_hook_attributes_active

@gr2m @Berkmann18 all looks good now. how can we test live?

tenshiAMD

@Berkmann18 @gr2m almost forgot, we need to update the documentation regarding this one.

oh, it's already included here (https://github.com/all-contributors/all-contributors/blob/2fdeea1fbe1788e223d8f34923ab38ec6ab33934/docs/cli/configuration.md#L24)

tenshiAMD · 2022-09-12T02:15:43Z

@Berkmann18 @gr2m I think we should set the default to use angular since that's the currently being used right now

tenshiAMD · 2022-09-12T02:40:14Z

Resolves #132

gr2m

looks good 👍🏼

github-actions · 2022-09-12T19:25:36Z

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

…ing-multiple-users-in-a-single-message * origin/master: (103 commits) feat: commit conventions (#343) refactor: remove unnecessary error handling (#410) chore: fix codecov (#409) chore: remove all Slack references (#407) docs: add tenshiAMD as a contributor for code, maintenance, bug, review, test (#408) chore(deps): bump validator and smee-client (#406) fix(deps): bump `all-contributors-cli` (#404) fix(package): bump `all-contributors-cli` (#403) chore(deps): bump async from 3.2.1 to 3.2.3 (#396) chore(deps): bump eventsource from 1.1.0 to 1.1.1 chore(deps): bump minimist from 1.2.5 to 1.2.6 chore(deps): bump url-parse from 1.5.7 to 1.5.10 chore(deps): bump node-fetch from 2.6.5 to 2.6.7 chore(deps): bump url-parse from 1.5.3 to 1.5.7 fix: bump max number of files to 25 (#385) docs: add aaltat as a contributor for bug (#383) fix: set `webhooksPath` correctly fix: Probot v12 (#381) chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9 chore(deps): bump semver-regex from 3.1.2 to 3.1.3 ...

Berkmann18 · 2022-09-13T17:08:03Z

@Berkmann18 @gr2m I think we should set the default to use angular since that's the currently being used right now

Not every repo use a commit convention and the setting was the users not just us.

tenshiAMD · 2022-09-13T18:15:05Z

Not every repo use a commit convention and the setting was the users not just us.

@Berkmann18 yes that's true however in the app the default is using angular. is CLI currently using none?

Berkmann18 · 2022-09-13T18:50:37Z

They both should have been the same, it must have been a mistake or a leftover from some corrections.

update: re-do the changes

262dda7

fix(lib): use a more direct approach

f914ee3

vercel bot deployed to Preview January 19, 2021 09:00 View deployment

Berkmann18 added 2 commits January 19, 2021 19:53

feat(add-contributor): make the PR title consistent with the commit c…

5923353

…onvention used

test(issue_comment): snapshot update

348a5df

It would need to be aware of the configuration used to test for the other conventions

vercel bot deployed to Preview January 19, 2021 19:56 View deployment

Merge branch 'master' into commit-conv

ee8738a

vercel bot had a problem deploying to Preview November 29, 2021 22:33 Failure

fix(lockfile): merge fix

d84a210

vercel bot had a problem deploying to Preview November 29, 2021 22:36 Failure

tenshiAMD requested changes Sep 6, 2022

View reviewed changes

tenshiAMD added the enhancement New feature or request label Sep 6, 2022

Merge branch 'master' into commit-conv

800b001

vercel bot had a problem deploying to Preview September 6, 2022 20:35 Failure

tenshiAMD added the pinned label Sep 6, 2022

chore: fix conflicts

c50d366

vercel bot deployed to Preview September 12, 2022 01:32 View deployment

Merge branch 'master' into commit-conv

f534639

vercel bot deployed to Preview September 12, 2022 01:45 View deployment

tenshiAMD approved these changes Sep 12, 2022

View reviewed changes

tenshiAMD requested changes Sep 12, 2022

View reviewed changes

vercel bot deployed to Preview September 12, 2022 02:19 View deployment

tenshiAMD mentioned this pull request Sep 12, 2022

docs: set commitConvention default to angular all-contributors/all-contributors#628

Merged

3 tasks

tenshiAMD approved these changes Sep 12, 2022

View reviewed changes

tenshiAMD requested a review from gr2m September 12, 2022 10:04

tenshiAMD force-pushed the commit-conv branch from d351345 to e08865a Compare September 12, 2022 18:10

vercel bot deployed to Preview September 12, 2022 18:11 View deployment

chore: set angular as default for commitConvention

70fe001

tenshiAMD force-pushed the commit-conv branch from e08865a to 70fe001 Compare September 12, 2022 19:22

vercel bot deployed to Preview September 12, 2022 19:22 View deployment

gr2m approved these changes Sep 12, 2022

View reviewed changes

gr2m merged commit e6c6571 into master Sep 12, 2022

gr2m deleted the commit-conv branch September 12, 2022 19:24

github-actions bot added the released label Sep 12, 2022

Mhmonicox mentioned this pull request Feb 16, 2023

[Snyk] Upgrade all-contributors-cli from 6.20.0 to 6.24.0 Mhmonicox/app#4

Open

snyk-bot mentioned this pull request Jun 1, 2023

[Snyk] Upgrade all-contributors-cli from 6.20.0 to 6.25.0 Mhmonicox/app#7

Open

Mhmonicox mentioned this pull request Jul 5, 2023

[Snyk] Upgrade all-contributors-cli from 6.20.0 to 6.26.0 Mhmonicox/app#9

Open

Mhmonicox mentioned this pull request Aug 2, 2023

[Snyk] Upgrade all-contributors-cli from 6.20.0 to 6.26.1 Mhmonicox/app#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: commit conventions #343

feat: commit conventions #343

Berkmann18 commented Jan 18, 2021 •

edited

vercel bot commented Jan 18, 2021 •

edited

gr2m commented Jan 18, 2021

Berkmann18 commented Jan 18, 2021

gr2m commented Jan 18, 2021

gr2m commented Oct 20, 2021

Berkmann18 commented Nov 29, 2021

tenshiAMD left a comment

tenshiAMD commented Sep 6, 2022

vercel bot commented Sep 6, 2022 •

edited

Berkmann18 commented Sep 6, 2022

codecov bot commented Sep 12, 2022 •

edited

tenshiAMD commented Sep 12, 2022

tenshiAMD left a comment •

edited

tenshiAMD commented Sep 12, 2022 •

edited

tenshiAMD commented Sep 12, 2022

gr2m left a comment

github-actions bot commented Sep 12, 2022

Berkmann18 commented Sep 13, 2022

tenshiAMD commented Sep 13, 2022

Berkmann18 commented Sep 13, 2022

feat: commit conventions #343

feat: commit conventions #343

Conversation

Berkmann18 commented Jan 18, 2021 • edited

vercel bot commented Jan 18, 2021 • edited

gr2m commented Jan 18, 2021

Berkmann18 commented Jan 18, 2021

gr2m commented Jan 18, 2021

gr2m commented Oct 20, 2021

Berkmann18 commented Nov 29, 2021

tenshiAMD left a comment

Choose a reason for hiding this comment

tenshiAMD commented Sep 6, 2022

vercel bot commented Sep 6, 2022 • edited

Berkmann18 commented Sep 6, 2022

codecov bot commented Sep 12, 2022 • edited

Codecov Report

tenshiAMD commented Sep 12, 2022

tenshiAMD left a comment • edited

Choose a reason for hiding this comment

tenshiAMD commented Sep 12, 2022 • edited

tenshiAMD commented Sep 12, 2022

gr2m left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 12, 2022

Berkmann18 commented Sep 13, 2022

tenshiAMD commented Sep 13, 2022

Berkmann18 commented Sep 13, 2022

Berkmann18 commented Jan 18, 2021 •

edited

vercel bot commented Jan 18, 2021 •

edited

vercel bot commented Sep 6, 2022 •

edited

codecov bot commented Sep 12, 2022 •

edited

tenshiAMD left a comment •

edited

tenshiAMD commented Sep 12, 2022 •

edited