Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display a meaningful error when the config file is missing #288

Merged
merged 7 commits into from
Oct 4, 2020

Commits on Oct 3, 2020

  1. feat: display a meaningful error when the config file is missing

    ## What
    
    When you try to add a user with `.all-contributorsrc` missing, you will get a cryptic error message (see also all-contributors/all-contributors#378):
    
    ```
    $ all-contributors add darekkay maintenance
    Cannot read property 'then' of null
    ```
    
    This PR displays a meaningful error message in this case.
    
    ## Why
    
    So users know what's causing the problem.
    
    ## How
    
    Before a contribution is being added, the script checks whether the config file exists. If it doesn't, an error message is being displayed:
    
    ```
    $ all-contributors add darekkay maintenance
    Configuration file not found: C:\projects\test\.all-contributorsrc
    ```
    darekkay committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    26ddea2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    984237e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Configuration menu
    Copy the full SHA
    7ea26c6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c3dbd7e View commit details
    Browse the repository at this point in the history
  3. refactor: fixed typos

    Berkmann18 committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    294d97d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    46857a0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2b5dbb4 View commit details
    Browse the repository at this point in the history