Development/lab 7 #216

notcruz · 2023-02-15T21:14:57Z

…/Lab-7

…repair part of exercise

Mster115 · 2023-02-28T13:39:55Z

Also could you add a button at the bottom that allows transition to an exercise end wrapping up what they learned and turning gamestate back to idle so they can navigate the site.

Mster115 · 2023-02-28T13:41:07Z

Also could you add a button at the bottom that allows transition to an exercise end wrapping up what they learned and turning gamestate back to idle so they can navigate the site.

At the end it should also have a button that returns the exercise to the exercise start page, or to the reinforcement page whatever makes the most sense.

Mster115

Final remarks above

AndreasLc1103

Some minor fixes. also, could you include it in the git ignore to ignore changes to the eslintrcs

client/src/components/exercise/lab7/components/Code.js

client/src/components/exercise/lab7/Main.js

client/src/services/lab7/RepairService.js

notcruz · 2023-03-01T21:39:12Z

Lab 7 Review

More Info

Nice job with this. It is very clear and concise.

Would this sound better as either "through a cybersecurity lens." or "with a focus on cybersecurity." ?

About

Looks good! I just noticed a missing comma (below).

Reading

Excellent job with the reading section, I found it incredibly informative. I only have a couple of small comments.

Would this sound better without the second "to you" ? ie, "Whether cybersecurity seems interesting to you, or irrelevant, anyone who uses the internet ..."

Great statistic!

With the rise of AI chatbots like ChatGPT, scammers can quickly and cheaply produce more convincing phishing emails and webpages. It might be worth including something about this in the reading section.

This would be binary classification. There are other forms of classification, such as multi-class classification. This might be rephrased as: "The algorithm categorizes the output into distinct classes: yes or no, true or false, or a letter of the alphabet (in a letter recognition model)."

Exercise

Instructions

The instructions are rather dense. I think they would benefit from some white space between nested bullet sections.

Is this meant to say 'sensitivity level'?

Exercise

These were all home address, resulting in the message staying the same each time.

Clicking update doesn't appear to do anything. It was only when I scrolled up that I saw the message that the fixed was applied. This could be fixed by having the page scroll up when the fix is successful.

I don't see the utility of going through the repair section multiple times since the inputs only ask for a specific value. Is there something I'm missing?

After applying the fix, the AI was still marked as having made many mistakes. Overall I had a hard time grokking how the activity worked, specifically around the connection between a file's sensitivity level and whether it should be open or locked for a particular threat level.

Reinforcement

The last two reinforcement videos are around 18 minutes long. Because of this, the likelihood that a user will follow through and watch them is low. Here are a couple alternatives that might be considered:

Artificial Intelligence for smarter Cybersecurity

Applying Deep Learning To Detect Any Cyber-Threat

Quiz

These two sentences are missing a subject ("models").

"Machine learning models are expensive to develop and to use" - "Machine learning models need to perform well to replace humans in the workplace"

Thanks for the review! Updated the lab accordingly.

notcruz · 2023-03-01T21:39:55Z

Small change before merge, can the repair close after update button is submitted successfully to make next button more prominent. Also follows format of other labs

Updated functionality

notcruz · 2023-03-01T21:40:29Z

Also could you add a button at the bottom that allows transition to an exercise end wrapping up what they learned and turning gamestate back to idle so they can navigate the site.

At the end it should also have a button that returns the exercise to the exercise start page, or to the reinforcement page whatever makes the most sense.

Updated and Fixed

Mster115 · 2023-03-03T21:56:59Z

Also could you add a button at the bottom that allows transition to an exercise end wrapping up what they learned and turning gamestate back to idle so they can navigate the site.

At the end it should also have a button that returns the exercise to the exercise start page, or to the reinforcement page whatever makes the most sense.

Updated and Fixed

@notcruz is there a button that goes to an exercise end page? or a return to beginning of exercise?

notcruz · 2023-03-03T22:03:53Z

Also could you add a button at the bottom that allows transition to an exercise end wrapping up what they learned and turning gamestate back to idle so they can navigate the site.

At the end it should also have a button that returns the exercise to the exercise start page, or to the reinforcement page whatever makes the most sense.

Updated and Fixed

@notcruz is there a button that goes to an exercise end page? or a return to beginning of exercise?

Yeah, the state is updated to EXERCISE_IDLE. Are you running on the latest changes? I'll have Dom check it out as well.

Mster115 · 2023-03-05T03:05:40Z

Also could you add a button at the bottom that allows transition to an exercise end wrapping up what they learned and turning gamestate back to idle so they can navigate the site.

At the end it should also have a button that returns the exercise to the exercise start page, or to the reinforcement page whatever makes the most sense.

Updated and Fixed

@notcruz is there a button that goes to an exercise end page? or a return to beginning of exercise?

Yeah, the state is updated to EXERCISE_IDLE. Are you running on the latest changes? I'll have Dom check it out as well.

@notcruz addressed offline waiting for change

stthazin

I just wanted to point out some typos - very brief review

stthazin · 2023-03-06T15:37:00Z

client/src/constants/lab7/index.js

+  "Home Address":
+    "Someone’s home address was stolen during the security breach. As a result of the breach, an identity thief was able to change the individual’s mailing address and reroute their mail to another address. This autonomous system decision-mistake caused a case of address fraud.",
+  "Mother Maiden Name":
+    "Someone’s mother's maiden was stolen during the security breach. As a result of the breach, an identity thief was able to answer the individual's security questions for all their accounts. This autonomous system decision-mistake caused a case of hacking and identity fraud.",


I think you meant to say "maiden name"

stthazin · 2023-03-06T15:38:11Z

client/src/constants/lab7/index.js

+  "Mother Maiden Name":
+    "Someone’s mother's maiden was stolen during the security breach. As a result of the breach, an identity thief was able to answer the individual's security questions for all their accounts. This autonomous system decision-mistake caused a case of hacking and identity fraud.",
+  "Full Name":
+    "Someone’s full was stolen during the security breach. As a result of the breach, an identity thief was able to sign up and create fake accounts under the individual's name. This autonomous system decision-mistake caused a case of identity fraud.",


same thing here - "full name"

stthazin · 2023-03-06T15:39:12Z

client/src/constants/lab7/index.js

+export const THREAT_LEVEL_TEXT = { 1: "Low", 2: "Medium", 3: "High" };
+
+export const MESSAGES = {
+  SSN: "Someone’s social security number was stolen during the security breach. As a result of the breach, an identity thief was able to steal an individual's identity. This autonomous system decision-mistake caused a case of indentity theft.",


typo in "identity" at the end

stthazin

Just some more grammatical things

client/src/components/exercise/lab7/components/File.js

stthazin · 2023-03-06T16:29:20Z

client/src/components/exercise/lab7/pages/ExerciseStart.js

+              </li>
+              <li>
+                At the end, a summary report containing all of the information
+                displayed throughout the simulation will be displayed


full stop at the end?

I'm a bit confused here, what do you mean?

"." a period at the end I believe
@notcruz

stthazin · 2023-03-06T16:30:46Z

client/src/components/exercise/lab7/pages/ImproveAICode/AICodeRepair.js

+              <p className={"playthrough__sentence"}>
+                Your goal should be to implement a utility equation into the
+                autonomous system. The utility equation is calculated by
+                weighting the reward of a decision and the cost of making said


"weighing" instead of "weighting"

stthazin · 2023-03-06T16:31:49Z

client/src/components/exercise/lab7/pages/Simulation/BadAIExplanation.js

+        </p>
+        <p className="playthrough__sentence">
+          This is due to the factors of the files that the AI is using to
+          determine in a file&lsquo;s access should be restricted or not.


I think this is "determine if" instead of "in"?

stthazin · 2023-03-06T16:34:55Z

client/src/constants/lab7/index.js

+
+export const POPUP_MESSAGES = {
+  INVALID_EXPRESSION: "You must pass a valid expression.",
+  ZERO_DIVISION: "Zero division is not allowed.",


"Division by zero" is the correct term I think

stthazin · 2023-03-06T16:35:07Z

client/src/constants/lab7/index.js

+export const ROUND_LIMIT = 10;
+
+export const POPUP_MESSAGES = {
+  INVALID_EXPRESSION: "You must pass a valid expression.",


notcruz · 2023-03-07T22:01:59Z

Looking into a bug that causes the modal div to still be on the Elements Tree even though the div is disabled.

notcruz · 2023-03-08T03:25:17Z

Looking into a bug that causes the modal div to still be on the Elements Tree even though the div is disabled.

Found this issue online. I believe the bug came from the setTimeout invocations, which updated the states at the wrong times. I updated/fixed the timing, which has fixed the problem.

Mster115 · 2023-03-08T14:50:19Z

NOTES: For now everything seems fine, possible typos addressed in hotfix, and addressing repair page instructions

kxl1360 and others added 30 commits March 7, 2022 13:27

Merge branch 'dev' of https://github.com/all-rit/ALL into development…

fc00ce1

…/Lab-7

stubbed out pages for lab 7 and added lab7 route to routes/index.js

49e4589

rm

d88ca1e

create lab7 client side

e5f4366

working url to Lab 7 page

4869b04

more skeleton pages

64f3ba0

lab 7 server files

e3259f3

Lab 7 reading in database and created exercise pages

3775614

create rest of exercise pages and fixed routing

b0097a2

create quiz skeleton

d8d184d

small formatting tweaks

707112e

create components and added them to pages

3c6bb08

create missing main components and fixed reducers for lab7

42612e8

minor css change to sim summary

5455470

refined components and add imgs for sim

5e8fe46

create missing sim components and add scss file

1862166

sim ui 90% done, mostly css work

3f9a3c9

fix button css

6c890af

fix button css pt 2

9be63bd

simulation update

7ae9481

found issue with file reset after each round

c1c1cd4

repair done

1d53160

added quiz and changed lab7 exercise table

2d94773

add alteration exercise quiz

50e2bcd

added comment to repair and found simulation running issues found in …

74a1218

…repair part of exercise

fixed naming issues

8a11b11

fixed typos and parameter mistakes

ed2b9a5

pushing missed file

aa0cb4e

Merged from dev and fixed conflicts

9fd78a6

Handling eslint errors

d7abdcf

Mster115 requested changes Feb 28, 2023

View reviewed changes

AndreasLc1103 reviewed Feb 28, 2023

View reviewed changes

[#216] Ryan's review implementation

23b819f

notcruz added a commit that referenced this pull request Mar 1, 2023

[#216] Andreas' review implementation

7ec7b04

notcruz added a commit that referenced this pull request Mar 1, 2023

[#216] Andreas' review implementation

2a0e7db

notcruz force-pushed the development/Lab-7 branch from 7ec7b04 to 2a0e7db Compare March 1, 2023 22:45

[#216] Andreas' review implementation

a41c6f7

notcruz force-pushed the development/Lab-7 branch from 2a0e7db to a41c6f7 Compare March 1, 2023 22:47

stthazin requested changes Mar 6, 2023

View reviewed changes

Updates based on demo

61fe07b

More updates

f8d285b

Mster115 and others added 3 commits March 8, 2023 09:37

Merge branch 'dev' into development/Lab-7

5665c77

fixed change effected by previous defect

f74d1fe

prettier fixes

fa9efff

Mster115 added 2 commits March 8, 2023 10:13

fixed ending of exercise

388ef6d

prettier fixes

2a330e9

Mster115 merged commit 2d881f2 into dev Mar 8, 2023

AndreasLc1103 deleted the development/Lab-7 branch September 19, 2023 01:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Development/lab 7 #216

Development/lab 7 #216

notcruz commented Feb 15, 2023 •

edited by dm9965

Mster115 commented Feb 28, 2023

Mster115 commented Feb 28, 2023

Mster115 left a comment

AndreasLc1103 left a comment

notcruz commented Mar 1, 2023

Lab 7 Review

More Info

About

Reading

Exercise

Instructions

Exercise

Reinforcement

Quiz

notcruz commented Mar 1, 2023

notcruz commented Mar 1, 2023

Mster115 commented Mar 3, 2023

notcruz commented Mar 3, 2023

Mster115 commented Mar 5, 2023

stthazin left a comment

stthazin Mar 6, 2023

stthazin Mar 6, 2023

stthazin Mar 6, 2023

stthazin left a comment

stthazin Mar 6, 2023

notcruz Mar 7, 2023

Mster115 Mar 8, 2023

stthazin Mar 6, 2023

stthazin Mar 6, 2023

stthazin Mar 6, 2023

stthazin Mar 6, 2023

notcruz commented Mar 7, 2023

notcruz commented Mar 8, 2023

Mster115 commented Mar 8, 2023

Development/lab 7 #216

Development/lab 7 #216

Conversation

notcruz commented Feb 15, 2023 • edited by dm9965

Mster115 commented Feb 28, 2023

Mster115 commented Feb 28, 2023

Mster115 left a comment

Choose a reason for hiding this comment

AndreasLc1103 left a comment

Choose a reason for hiding this comment

notcruz commented Mar 1, 2023

Lab 7 Review

More Info

About

Reading

Exercise

Instructions

Exercise

Reinforcement

Quiz

notcruz commented Mar 1, 2023

notcruz commented Mar 1, 2023

Mster115 commented Mar 3, 2023

notcruz commented Mar 3, 2023

Mster115 commented Mar 5, 2023

stthazin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stthazin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

notcruz commented Mar 7, 2023

notcruz commented Mar 8, 2023

Mster115 commented Mar 8, 2023

notcruz commented Feb 15, 2023 •

edited by dm9965