Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

581 story stub out jest in architecture #582

Merged
merged 4 commits into from
Apr 2, 2024
Merged

581 story stub out jest in architecture #582

merged 4 commits into from
Apr 2, 2024

Conversation

AndreasLc1103
Copy link
Contributor

  • No discrepancies across browsers. Eg. chrome vs safari
  • Pages pass W3C Validation for HTML (https://validator.w3.org)
  • CSS (https://jigsaw.w3.org/css-validator/)
  • Google sign-in is operational
  • Accessibility functions
  • Pages can scale without distorting page
  • No dead links
  • Navbar is consistent across the site
  • Pages are screen-reader accessible
  • Contrast meets standards for accessibility
  • Pages are keyboard accessible
  • Passes WAVE Evaluation Tool chrome extension

@AndreasLc1103 AndreasLc1103 added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 1, 2024
@AndreasLc1103 AndreasLc1103 added this to the Finish CI/CD Pipeline milestone Apr 1, 2024
@AndreasLc1103 AndreasLc1103 self-assigned this Apr 1, 2024
@AndreasLc1103 AndreasLc1103 linked an issue Apr 1, 2024 that may be closed by this pull request
Story: Stub out jest in architecture #581
Closed
16 tasks
heathermoses
heathermoses approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by making a commit and ensuring that the test suite ran and that I couldn't push unless tests passed. Looks good!

dm9965
dm9965 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@dm9965 dm9965 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest runs properly and tests specified cases. Approved.

@AndreasLc1103 AndreasLc1103 merged commit 13dca43 into dev Apr 2, 2024
3 checks passed
@AndreasLc1103 AndreasLc1103 deleted the 581-story-stub-out-jest-in-architecture branch April 2, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heathermoses heathermoses heathermoses approved these changes

@dm9965 dm9965 dm9965 approved these changes

Assignees

@AndreasLc1103 AndreasLc1103

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
Accessible Learning Labs
Status: Done
Milestone
Finish CI/CD Pipeline
Development

Successfully merging this pull request may close these issues.

Story: Stub out jest in architecture
3 participants
@AndreasLc1103 @heathermoses @dm9965