Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

558 story create about section for lab 12 #585

Merged

Conversation

dm9965
Copy link
Contributor

@dm9965 dm9965 commented Apr 2, 2024

  • No discrepancies across browsers. Eg. chrome vs safari
  • Pages pass W3C Validation for HTML (https://validator.w3.org)
  • CSS (https://jigsaw.w3.org/css-validator/)
  • Google sign-in is operational
  • Accessibility functions
  • Pages can scale without distorting page
  • No dead links
  • Navbar is consistent across the site
  • Pages are screen-reader accessible
  • Contrast meets standards for accessibility
  • Pages are keyboard accessible
  • Passes WAVE Evaluation Tool chrome extension

@dm9965 dm9965 linked an issue Apr 2, 2024 that may be closed by this pull request
14 tasks
@dm9965 dm9965 changed the base branch from dev to development/lab-12 April 2, 2024 20:36
Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dm9965 dm9965 merged commit c1cdb54 into development/lab-12 Apr 2, 2024
3 checks passed
@dm9965 dm9965 deleted the 558-story-create-about-section-for-lab-12 branch April 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Story: Create About Section for Lab 12
3 participants