Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

562 story create graduation application form component #592

Conversation

apr8760
Copy link
Collaborator

@apr8760 apr8760 commented Apr 10, 2024

Jest testing to come.
To test, add component to App.js --> "GradApplication path="/Lab12/Exercise/*" user={state.main.user} " and run.

  • No discrepancies across browsers. Eg. chrome vs safari
  • Pages pass W3C Validation for HTML (https://validator.w3.org)
  • CSS (https://jigsaw.w3.org/css-validator/)
  • Google sign-in is operational
  • Accessibility functions
  • Pages can scale without distorting page
  • No dead links
  • Navbar is consistent across the site
  • Pages are screen-reader accessible
  • Contrast meets standards for accessibility
  • Pages are keyboard accessible
  • Passes WAVE Evaluation Tool chrome extension

@apr8760 apr8760 linked an issue Apr 10, 2024 that may be closed by this pull request
16 tasks
@dm9965 dm9965 changed the base branch from dev to development/lab-12 April 10, 2024 22:39
dm9965

This comment was marked as outdated.

Copy link
Contributor

@dm9965 dm9965 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the red error handling to be aligned with the input box

Screenshot 2024-04-11 at 3 44 49 PM

Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Great job on your first PR! :)

@@ -0,0 +1,256 @@
/* eslint-disable no-unused-vars */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this eslint line

Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by ensuring the error handling works and making sure tests pass. Looks good

@heathermoses heathermoses merged commit 7755461 into development/lab-12 Apr 25, 2024
@heathermoses heathermoses deleted the 562-story-create-graduation-application-form-component branch April 25, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Story: Create Graduation Application Form Component
5 participants