-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
562 story create graduation application form component #592
562 story create graduation application form component #592
Conversation
…plication-form-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…nto 562-story-create-graduation-application-form-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Great job on your first PR! :)
@@ -0,0 +1,256 @@ | |||
/* eslint-disable no-unused-vars */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this eslint line
…story-create-graduation-application-form-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this by ensuring the error handling works and making sure tests pass. Looks good
Jest testing to come.
To test, add component to App.js --> "GradApplication path="/Lab12/Exercise/*" user={state.main.user} " and run.