Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

573 Story to Create Quiz Service #594

Merged
merged 26 commits into from
Apr 22, 2024
Merged

Conversation

AndreasLc1103
Copy link
Contributor

@AndreasLc1103 AndreasLc1103 commented Apr 11, 2024

573 Story to Create Quiz Service

closes #573

Description

This story is intended on finalizing the ability to making the quiz database driven and not dependent on the API directory., eliminating the need for extra files storing json within the codebase

User Story

  • As a Developer I would like to have the quiz database driven so we can update a single source of truth

  • No discrepancies across browsers. Eg. chrome vs safari

  • Pages pass W3C Validation for HTML (https://validator.w3.org)

  • CSS (https://jigsaw.w3.org/css-validator/)

  • Google sign-in is operational

  • Accessibility functions

  • Pages can scale without distorting page

  • No dead links

  • Navbar is consistent across the site

  • Pages are screen-reader accessible

  • Contrast meets standards for accessibility

  • Pages are keyboard accessible

  • Passes WAVE Evaluation Tool chrome extension

Testing instructions

  1. cd into database directory and drop the db container using docker compose down -v
  2. bring back up with docker compose up
  3. cd into the server directory and run npm test and ensure tests pass
  4. then use pm2 or manually run the setup
  5. go through the quizzes on the site

@AndreasLc1103 AndreasLc1103 linked an issue Apr 11, 2024 that may be closed by this pull request
18 tasks
@AndreasLc1103 AndreasLc1103 changed the title 573 story create quiz service 573 Story to Create Quiz Service Apr 12, 2024
@AndreasLc1103 AndreasLc1103 self-assigned this Apr 12, 2024
@AndreasLc1103 AndreasLc1103 added the enhancement New feature or request label Apr 12, 2024
@AndreasLc1103 AndreasLc1103 added this to the Finish CI/CD Pipeline milestone Apr 12, 2024
@AndreasLc1103 AndreasLc1103 marked this pull request as ready for review April 12, 2024 01:16
Copy link
Contributor

@dm9965 dm9965 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job cleaning up a ton of static code bloat that should've been in the db to begin with. Also updating the Lab Service to include updated, more secure methods is a good touch. Good job on the jest tests as well.

Copy link
Contributor

@heathermoses heathermoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I requested one small change, I'm approving in the meantime

When testing some of the quizzes, I got an undefined type error. Refreshing the page made the error go away, but I'm not sure why that would have happened
Screenshot 2024-04-22 at 10 52 53 AM

@AndreasLc1103
Copy link
Contributor Author

This looks good overall. I requested one small change, I'm approving in the meantime

When testing some of the quizzes, I got an undefined type error. Refreshing the page made the error go away, but I'm not sure why that would have happened Screenshot 2024-04-22 at 10 52 53 AM

resolved

@AndreasLc1103 AndreasLc1103 merged commit 16b590c into dev Apr 22, 2024
3 checks passed
@AndreasLc1103 AndreasLc1103 deleted the 573-story-create-quiz-service branch April 22, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Story: Create Quiz Service
3 participants