Update MSRV to 1.64.0 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In line with the project's Minimum Supported Rust Version policy. - Current rust version on 2023-08-08 is 1.71.0. - 8 versions ago is 1.63.0. - Bumped by 1 version to use latest version of clap.
|
|
|
I approve. @Dylan-DPC? |
|
Yeah sounds good to me, though this should be targeted towards a 0.16.0 release (i know it doesn't need to be considered a breaking change, but it just makes it easier for everyone concerned) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Minimum Supported Rust Verison policy is to support the last 8 rustc versions. As of 2023-08-08 that is from version 1.63.0 onwards.
Clap's MSRV is 1.64.0, and we have a PR to update to the lastest version. So I have bumped our MSRV to match.
The current CI tests do not pass with version 1.56.1 (due to dependencies having newer MSRVs) so I think it is worth doing now.