You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames the primary function that loads the dotenv file to
`load`.
`dotenv` is still around with a deprecation warning.
The renaming is discussed in [Discussion #39](#39).
This renaming follows the naming convention in Ruby and Go implementations, using [`Dotenv.load`](https://github.com/bkeepers/dotenv) and [`godotenv.Load`](https://github.com/joho/godotenv) respectively.
@allan2
Are you wishing to follow a more reserved or a more aggressive approach when it comes to getting these PRs merged and issues solved? I'm guessing, based on current behavior, that you're following a more reserved approach.
It might be worth considering being more aggressive, and possibly considering the next release a breaking one. This would allow us to implement a huge amount of these features we're trying to get in and a give us a nice foundation to work on from here.
Maybe a discussion could be opened about this, but ultimately it is your decision as the maintainer of the repository.
I have been making a lot of comments in the recent days. If I'm doing too much, please let me know. I do not want to overstep my role as a user of this repo.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the primary function that loads the dotenv file to
load.dotenvis still around with a deprecation warning.The renaming is discussed in #39.
This renaming follows the naming convention in Ruby and Go implementations, which use
Dotenv.loadandgodotenv.Loadrespectively.