Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option_dotenv! macro #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

aidenfarley
Copy link

@aidenfarley aidenfarley commented Apr 18, 2024

Closes #85

This is my first pull request on a public repository. Please let me know how I could do better to improve!

I am fairly new to Rust, so I am not 100% familiar with the conventions. Please suggest any changes you believe will help improve the usability, etc. of the feature.

Thank you.

@aidenfarley aidenfarley changed the title Add option_dotenvy! macro Add option_dotenv! macro Apr 18, 2024
@allan2
Copy link
Owner

allan2 commented Apr 18, 2024

Hi Aiden, thank you for your PR. I have noticed your enthusiasm in the multitude of comments left in this repo over the last day ;)

Heads up: this issue will have to wait for #101 which will probably take a while.

@allan2 allan2 added the enhancement New feature or request label Apr 18, 2024
@aidenfarley
Copy link
Author

Hello allan! I'm very excited to work with you and many others on this repository.

Why not merge this PR, then reconcile it with the decision made in the discussion for #101?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotenvy_macro could use a option_env!() macro
2 participants