Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support large ammount of datasources #1012

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

support large ammount of datasources #1012

wants to merge 5 commits into from

Conversation

adrianmroz-allegro
Copy link
Contributor

  • support huge amount of datacubes by adding spliting datacubes from clusters and adding pagination to the /sources/dataCubes
  • WIP: cubes paging

@adrianmroz-allegro adrianmroz-allegro marked this pull request as ready for review January 9, 2023 10:35
@adrianmroz-allegro adrianmroz-allegro requested a review from a team as a code owner January 9, 2023 10:35
@adrianmroz-allegro adrianmroz-allegro mentioned this pull request Jan 9, 2023
Open
@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited

size-limit report 📦

Path Size
build/public/main.js 1.74 MB (+0.2% 🔺)
build/public/polyfills.es5.js 42.71 KB (+0.01% 🔺)
build/public/dnd.es5.js 4.61 KB (0%)

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

⏱️ Lighthouse report

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

⏱️ Lighthouse report

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app

@adrianmroz-allegro adrianmroz-allegro force-pushed the support-large-ammount-of-datasources branch from a8a1136 to f1f5854 Compare January 9, 2023 12:46
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

⏱️ Lighthouse report

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app

mkuthan
mkuthan requested changes Jan 9, 2023
View reviewed changes
src/client/utils/ajax/ajax.ts Show resolved Hide resolved
src/client/utils/ajax/ajax.mocha.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

⏱️ Lighthouse report

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

✅ Deployed successfully to: https://turnilo-support-large-ammount-of-datasources-gmbbyye42a-ew.a.run.app

mkuthan
mkuthan approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@mkuthan mkuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for additional test scenarios!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuthan mkuthan mkuthan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adrianmroz-allegro @mkuthan @SingularVlad