Fix path substitution for file:// URIs #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything missing / any way to speed this up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue \ discussion
Fix for #1233. See also #1217.
Patch Description
Perform url canonization in
StorageHelper.get_driver_direct_access(). It is performed in all relevant methods onStorageHelper: here and here and here and here and here and here and here.Testing Instructions
Described in #1233.
Other Information
Test for dataset creation and loading. Loading works as expected. Creation works and will write the data to the path with substitution applied while the stored name will not have substitution applied (this is the expected behavior).
I could only test for
file://. Could not check the effect on other uri types (e.g., AWS).