Skip to content

Commit

Permalink
Merge pull request #13 from allen-cell-animated/fix/dep-error
Browse files Browse the repository at this point in the history
installing fixed version of protobufjs
  • Loading branch information
meganrm committed Jun 25, 2020
2 parents ea4b4d1 + bdef342 commit 7b15a14
Show file tree
Hide file tree
Showing 4 changed files with 2,767 additions and 4,802 deletions.
9 changes: 8 additions & 1 deletion README.md
Expand Up @@ -47,7 +47,14 @@ Differences in builds by environment:
| dev | true | false | false |
| staging| true | false | false |
| production| false | true | true |
___

*Note as of June 25, 2020*: To deal with an error `~/cell-feature-explorer/node_modules/@grpc/proto-loader/node_modules/protobufjs/src/root.js:236
throw Error("not supported");`
^
protobufjs has code that fixes this error, but it's not yet included in a stable release: [PR](https://github.com/protobufjs/protobuf.js/pull/1363/), so we're using the beta version of 6.10. It looks like it's planned to be included in 6.9.1 as soon as they can verify it doesn't break things.
Also, to make sure grpc wasn't installing an older version of protobufjs, it has been removed it from the package's dependencies and the package-lock file as been shrinkwrapped.

TODO in the future, once there is a stable release of protobufjs with this fix, and grpc has been updated to depend on it, we can remove these changes.


### Deployment
Expand Down

0 comments on commit 7b15a14

Please sign in to comment.