Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installing fixed version of protobufjs #13

Merged
merged 6 commits into from
Jun 25, 2020
Merged

installing fixed version of protobufjs #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c1b238
installing fixed version of protobufjs
meganrm Jun 25, 2020
e45c563
manually edited and shrinkwrapped package-lock
meganrm Jun 25, 2020
5081cb7
delinting
meganrm Jun 25, 2020
c2e9792
changing requires version
meganrm Jun 25, 2020
fdae316
bumping prtobufjs version
meganrm Jun 25, 2020
bdef342
adding note to the readme about bug
meganrm Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,14 @@ Differences in builds by environment:
| dev | true | false | false |
| staging| true | false | false |
| production| false | true | true |
___

*Note as of June 25, 2020*: To deal with an error `~/cell-feature-explorer/node_modules/@grpc/proto-loader/node_modules/protobufjs/src/root.js:236
throw Error("not supported");`
^
protobufjs has code that fixes this error, but it's not yet included in a stable release: [PR](https://github.com/protobufjs/protobuf.js/pull/1363/), so we're using the beta version of 6.10. It looks like it's planned to be included in 6.9.1 as soon as they can verify it doesn't break things.
Also, to make sure grpc wasn't installing an older version of protobufjs, it has been removed it from the package's dependencies and the package-lock file as been shrinkwrapped.

TODO in the future, once there is a stable release of protobufjs with this fix, and grpc has been updated to depend on it, we can remove these changes.


### Deployment
Expand Down