Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Fix for #4227 #4231

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix for #4227 #4231

wants to merge 1 commit into from

Conversation

softwareCobbler
Copy link

Attempted fix for #4227

@mojoaxel mojoaxel added this to the Minor Release v4.22 milestone Jan 23, 2019
@mojoaxel mojoaxel self-requested a review January 23, 2019 08:08
@jgorene
Copy link

jgorene commented Feb 5, 2019 •
edited

Hello there,
I'm following some pull requests to see where I can help to move forward on v4.22.

Edited
My mistake, sorry! I should have first gone to the develop branch and for me this option was fixed fine by @yotamberk, in fact 👍 .
Nevertheless, it would seem that the "toggleRollingMode ()" method still does not work if the "rollingMode" is not defined in the options, at least a priori.

@asiby
Copy link

asiby commented Feb 19, 2019 •
edited

Hi guys. No offence, but I think it would help to just grab the fix from the timeline-plus project that got forked from this one. It is at https://github.com/yotamberk/timeline-plus

They have the rollingMode working just fine.

@mojoaxel mojoaxel mentioned this pull request Aug 2, 2019
Closed
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Timeline
Projects
None yet
Milestone
Minor Release v4.22
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@softwareCobbler @jgorene @asiby @mojoaxel @yotamberk