Add clang-13 to CI #1485
Merged
Add clang-13 to CI #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like |
|
At the moment, I working on this subject for the GitLab Container. You need to add the following ppa's: |
bernhardmgruber
force-pushed
the
clang13
branch
from
50de3e6
to
047a738
Compare
j-stephan
previously approved these changes
Dec 3, 2021
|
Okay, we finally hit the Catch2 bug, @j-stephan reported a while ago: catchorg/Catch2#578 /home/runner/work/alpaka/alpaka/test/integ/mandelbrot/src/mandelbrot.cpp:259:1: error: identifier '____C_A_T_C_H____T_E_M_P_L_A_T_E____T_E_S_T____F_U_N_C____0' is reserved because it starts with '__' [-Werror,-Wreserved-identifier] |
bernhardmgruber
force-pushed
the
clang13
branch
from
047a738
to
397358e
Compare
bernhardmgruber
force-pushed
the
clang13
branch
from
397358e
to
45c7bdb
Compare
|
Catch2 issue is fixed on their development branch, includes in this PR. |
bernhardmgruber
force-pushed
the
clang13
branch
from
45c7bdb
to
c169271
Compare
|
Also fixes #1388. |
psychocoderHPC
requested changes
Dec 17, 2021
bernhardmgruber
force-pushed
the
clang13
branch
from
c169271
to
6004179
Compare
psychocoderHPC
approved these changes
Dec 17, 2021
|
This PR passed already the CI but a change in the README was required, therefore I will merge it before the CI is passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds clang-13 to the CI and updates the Catch2 version used.
Fixes #1476.
The new Catch2 version is unreleased. It contains an important bug fix that is necessary to compile with clang-13. Since we vendor Catch2 ourselves, everybody who builds with the vendored Catch2 can build the alpaka tests using clang-13. Everybody else, that uses their own Catch2, can still build all unit tests but not with clang-13, until Catch2 releases a new version including the bug fix.