Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Previous PRs have resolved some of the issues around lists and links. The differences in the build for this PR are: eg: GOV.UK Design System becomes `id="govuk-design-system` instead of `id="gov-uk-design-system` I think this is a good change - it avoids weirdness like `you-re` or `that-s` and also cleans up some stray dashes (see line 2149 of `public/components/accordion/index.html`) See: markedjs/marked#1532 For an example, see line 1143 of `public/components/cookie-banner/index.html`, which gets its wording from https://github.com/alphagov/govuk-design-system/blob/7021e0d192ee3c62bdde382c463396fed1d2959a/src/components/cookie-banner/default/index.njk#L2 I'm uncertain as to whether this is good. I think it's fine, but there's a change some delicate spacing thing could be thrown out by it Pedantic rules are not meant to support fenced code blocks. I haven't tracked down the exact fix, but this was clearly a bug in `marked`'s implementation - I'm guessing the pedantic rules at least in this case didn't override `gfm` for some reason (since we had both set to `true`). In later versions of `marked`, this has been fixed, and since we're using `pedantic` all of our code blocks are treated as standard paragraphs. Whelp! There doesn't appear to be a fix for this while still using `pedantic`, so the next step is to try and use `gfm`. Theoretically it should be fine - the changes we've made so far are very compliant, so should be supported by `gfm`.
- Loading branch information
1 parent
0e0aec0
commit 1471aa7
Showing
28 changed files
with
101 additions
and
130 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.