Tidy up how our sass and js is imported #3807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Makes 3 changes across our sass and js importing and initialisation:
'govuk-frontend'
govuk-frontend#4957 is resolved and publishedcreateAll
method to initialise our js following it's introduction in Move responsibilities frominitAll
to the components govuk-frontend#4945all
from the sass import paths as per the changes in Rename any_all.scss
files to_index.scss
so they work as index files govuk-frontend#4960Why
This is a redux of #3732 following all the work done via #3731 in the last cycle.
Notes
There are no changes in file size for compiled js and css assets between
main
and this branch. The primary benefit is that the build now no longer spits out a bunch of sass warnings and our imports are a bit neater.