Support cmd.exe and PowerShell #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-support-powershell
branch
3 times, most recently
from
8bfa24b
to
f939afe
Compare
lfdebrux
changed the title
lfdebrux
force-pushed
the
ldeb-support-powershell
branch
from
2eca161
to
a03a5ec
Compare
lfdebrux
changed the title
lfdebrux
force-pushed
the
ldeb-support-powershell
branch
3 times, most recently
from
09f2636
to
8982b0a
Compare
|
As well as testing this in CI, I tested this locally with a Windows laptop. After verifying I could reproduce the error reported in #1578 without these changes, I verified that the kit worked fine with the code in this PR. |
lfdebrux
force-pushed
the
ldeb-support-powershell
branch
3 times, most recently
from
ba7be0f
to
ff829df
Compare
Previously we forced GitHub Actions and npm to use bash as the shell on all operating systems, npm defaults to using cmd.exe on Windows [[1]], GitHub Actions defaults to using PowerShell on Windows [[2]]. This commit removes the overrides, and also fixes up the npm package scripts syntax to support cmd.exe. [1]: https://docs.npmjs.com/cli/v8/using-npm/config#script-shell [2]: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
lfdebrux
force-pushed
the
ldeb-support-powershell
branch
2 times, most recently
from
26370cc
to
32450ce
Compare
BenSurgisonGDS
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop showing users an error if they run the kit on Windows without using Bash.
Bash is no longer a requirement of running our tests or the kit, so this PR changes our tests to use the default shells on Windows rather than forcing the use of Bash.
We also change the
.npmrcfile the user receives so that it does not try and use bash fornpm runon Windows.