Skip to content

Commit

Permalink
BAU add problematic packages with unsafe deps
Browse files Browse the repository at this point in the history
React fixed at ^16 to meet the peer dependency of `@nivo` library, this
conflicts with requirements for react-spring which nivo actually uses.
This entire tangle should be moved out of this repository and into its
own component repository where it can be tracked and then resolved as
dependencies slowly updated. This shouldn't be something Toolbox devs
need to think about at the top level.

Dependencies installed with `--leagcy-peer-deps` because of tangled peer
dependencies not playing nicely with npm 7.
- react-spring
- react-inlinesvg
- @nivo/core, @nivo/line, @nice/stream

React spring issue causes a conflict with the lasest available
@types/react see pmndrs/react-spring#1102.

Because of this it has been fixed a few versions back, when react-spring
updates to the next release candidate (4) or has a formal major version
upgrade this restriction should be lifted.
  • Loading branch information
sfount committed Feb 8, 2021
1 parent 53d7891 commit 62957f5
Show file tree
Hide file tree
Showing 3 changed files with 14,870 additions and 25,722 deletions.
6 changes: 2 additions & 4 deletions browser/src/dashboard/EventCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import React from 'react'

import { Event } from './../../../src/web/modules/transactions/types/ledger'

import { BackgroundColorProperty, ColorProperty } from 'csstype'

import VisaIcon from './../assets/card_visa.svg'
import MastercardIcon from './../assets/card_mastercard.svg'
import AmexIcon from './../assets/card_amex.svg'
Expand All @@ -26,8 +24,8 @@ import { eventsActiveSuccess, eventsErrored } from './events'
import { currencyFormatter } from './format'

interface CardProfile {
backgroundColour: BackgroundColorProperty
colour: ColorProperty
backgroundColour: string,
colour: string
}

const SuccessProfile: CardProfile = {
Expand Down

0 comments on commit 62957f5

Please sign in to comment.