Attempt memory leak fix from using magics (#2832)

* Attempt memory leak fix from using magics * another potential fix for memory leak with magics maybe safer for some types of consumption --------- Co-authored-by: Byron Anderson <byron@geometer.io>
alpinejs · Apr 21, 2023 · 61bef0d · 61bef0d
1 parent 6142a83
commit 61bef0d
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/packages/alpinejs/src/magics.js b/packages/alpinejs/src/magics.js
@@ -11,17 +11,24 @@ export function magic(name, callback) {
 
 export function injectMagics(obj, el) {
     Object.entries(magics).forEach(([name, callback]) => {
-        Object.defineProperty(obj, `$${name}`, {
-            get() {
+        let memoizedUtilities = null;
+        function getUtilities() {
+            if (memoizedUtilities) {
+                return memoizedUtilities;
+            } else {
                 let [utilities, cleanup] = getElementBoundUtilities(el)
 
-                utilities = {interceptor, ...utilities}
+                memoizedUtilities = {interceptor, ...utilities}
 
                 onElRemoved(el, cleanup)
-
-                return callback(el, utilities)
+                return memoizedUtilities;
+            }
+        }
+
+        Object.defineProperty(obj, `$${name}`, {
+            get() {
+                return callback(el, getUtilities());
             },
-
             enumerable: false,
         })
     })