New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Makes .fill work with selects and other modifiers #3495
Conversation
e8c227b
to
bedbfc9
Compare
I'm just chiming in, do you think textareas support could be added to this PR? |
This PR is already covering that since it just triggers the event like a normal x-model (the current tagged implementation check for the existence of the value attribute which doesn't work for textareas). |
@saveman71 This PR should handle everything model works on, as it essentially taps in to the existing model handling to do the filling, as opposed to doing special paths or exceptions. So anything model works on, should now work with .fill if/when this PR is released. |
Very clear! I hadn't had a look at the code sorry but this implemention indeed seems more robust. Thanks a lot! Let's hope it gets merged :) |
@@ -87,7 +87,10 @@ function injectHtmlAndBootAlpine(cy, templateAndPotentiallyScripts, callback, pa | |||
}) | |||
} | |||
|
|||
export let haveData = (key, value) => ([ el ]) => expect(root(el)._x_dataStack[0][key]).to.equal(value) | |||
export let haveData = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, just a heads up, making non-code-changing, styling changes (especially to styles that diverge from the rest of the codebase), makes PR's harder for me to review and merge without putting extra work in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this note, would you be able to add the workspace settings/formatter settings you use to the repository?
Then it becomes automatic that anyone cloning the repo would have the same formatter.
I tried using Do you think it would work to just add |
This PR extends #3423 to support
select
elements and other modifier likenumber