Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Directs Vue Reactivity Import to Browser Version #3602

Closed
wants to merge 1 commit into from

Conversation

ekwoka
Copy link
Contributor

@ekwoka ekwoka commented May 27, 2023

Problem

As mentioned here and some other places, for people using outdated CDN systems for their JS, no longer bundling dependencies has caused some issues with @vue/reactivity.

Vue reactivity points to a version that is for the server, and bundlers are smart enough to handle this (and instead use the provided browser version right next to it).

However, some cdns that let people add packages in the browser do not do these kinds of checks, causing a failure.

Alpine used to prebundle all the dependencies, which masked this issue as Alpine's build step was handling this negotiation. However, prebundling dependencies is generally a bad practice as it can increase unneeded code duplication and reduce consumer control.

Solution

This solves should solve the problem by pointing the imports directly at the browser safe version of the module so that modern bundlers, and outdated systems alike can use the correct browser-safe version of the reactivity engine.

@calebporzio
Copy link
Collaborator

Going to close this as I'm not positive it will solve the problem. I reverted #3459 and tagged a new version (v3.12.2) that contains the fix for this. Thanks for this, but going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants